RF-mod 2.0 - electric boogaloo

Discuss mods and get help with mods ONLY
Emperor naru
User avatar
nwru
Administrator
Posts: 3529
Joined: October 14th, 2006
Location: /dev/null
Reputation: 64
Contact:

Postby nwru » Fri Apr 13, 2007 9:41 am

Rogue_F wrote:Because it's late tonight, I will probably release 3.0 tomorrow instead of tonight. I still need to fix the bug when the base_library is not set.
-Alex

Try to start a new thread for the new release. This one is getting a little unruly.

BTW, thanks for all your hard work =)
Last edited by nwru on Fri Apr 13, 2007 9:41 am, edited 1 time in total.
Use the Search feature first to find answers to your questions. Chances are that they have been asked before!

Forum FAQ / Frets On Fire Wiki
User avatar
Konador
Member
Posts: 333
Joined: February 12th, 2007
Location: England
Reputation: 2
Contact:

Postby Konador » Fri Apr 13, 2007 10:12 am

Amazing work! The HOPO is perfect and it even makes sense in custom songs! It's like the game is psychic! :)
Songs Completed:
- Dark Side of the Moon (Full) - Livin' on a Prayer - Life and Death
Mods Completed:
- Pink Floyd Mod - Spanish Castle Magic with VOCALS!
Playing Statistics:
Image
User avatar
winniez
Member
Posts: 2544
Joined: September 20th, 2006
Reputation: 11

Postby winniez » Fri Apr 13, 2007 11:13 am

2 littles things :

- folder color is not taken (it's color in doc, no cassettecolor, maybe you use cassettecolor... no idea)
- folders are not taken in the filter by letter key
not a robot
User avatar
raph666
Administrator
Posts: 2428
Joined: March 9th, 2007
Location: dans la mer du nord
Reputation: 20
Contact:

Postby raph666 » Fri Apr 13, 2007 11:17 am

Rogue_F I also have the string index out of range problem.

I have a folder with all my user's-made-downloaded songs in it, I tried all the 3way of sorting them and I have the error when I try to "jump" to a song by pressing a letter (no matter what sorting option is set). I should try to fix the .ini but I'll have to verify hundreds of them :p It must be related to those songs because it's working good in other folders with like, the GH songs
User avatar
winniez
Member
Posts: 2544
Joined: September 20th, 2006
Reputation: 11

Postby winniez » Fri Apr 13, 2007 11:45 am

another thing I noticed (not new) can you make the song sorting case unsensitive ?

Some people forget the caps at the song title and those songs are at the end of the list
Rogue_F
Member
Posts: 1504
Joined: November 2nd, 2006
Reputation: 1

Postby Rogue_F » Fri Apr 13, 2007 1:05 pm

winniez.

Folder color remains the same as in the previous RF-mod. It uses casettecolor. Folders don't filter. They just sort based on the first key you press a-z and 1-9 ascii only. Other character sets wont work.

I can probably change it to a caseinsensitive sort, but my folder stuff will probably go away in the 4.0 version. In the port to the new code I will just be using their way of doing things I have already done.


raph - If you understand what a binary search is, do that to figure out which folder is causing you the problem. I think the problem as reported by someone else is the 'artist =' in the song.ini was missing causing the problem. I dont recall fixing that bug.

And I will start a new 3.0 thread when 3.0 is out. Since it's not out yet, I did not want to put this in it.

-Alex
User avatar
Drac
Member
Posts: 22
Joined: February 27th, 2007
Reputation: 0

Postby Drac » Fri Apr 13, 2007 1:05 pm

hi thanks for this great mod, everything is near perfect.
Just one thing I notice with your HO/PO, while it's far better than the offcial one of FoF, it seems to have some problems. While playing Woman - Wolfmother of GH2, some frets which are supose to be Ho/Po activated were not, also in other songs, for the same portion of frets (but at differents moments of the song), sometimes they were Ho/Po "friendly" and sometimes not ???
Maybe your Ho/Po detection is too strict, I don't know.

Anyway thanks again for your mod!
User avatar
Konador
Member
Posts: 333
Joined: February 12th, 2007
Location: England
Reputation: 2
Contact:

Postby Konador » Fri Apr 13, 2007 1:09 pm

Rogue_F wrote:raph - If you understand what a binary search is, do that to figure out which folder is causing you the problem. I think the problem as reported by someone else is the 'artist =' in the song.ini was missing causing the problem. I dont recall fixing that bug.

Could you explain a binary search? I'm having the exact same problem
Songs Completed:

- Dark Side of the Moon (Full) - Livin' on a Prayer - Life and Death

Mods Completed:

- Pink Floyd Mod - Spanish Castle Magic with VOCALS!

Playing Statistics:

Image
Rogue_F
Member
Posts: 1504
Joined: November 2nd, 2006
Reputation: 1

Postby Rogue_F » Fri Apr 13, 2007 1:14 pm

Lets say you have 100 files in the folder that is affected.

You take the first 50 and move them to some other location.

Now you test. Do you still have the problem? If so, then the problem file is in the 50 remaining in the original folder, if not, then the problem folder is in the 50 remaining in the ones you moved to the other location.

you then take that set of 50, divide them in half again, move 25 away, and leave 25 there.

Now you test. If the problem is there, it's in the remaining 25, if the problem is not it is in the moved 25.

Repeat until you find your problem folder.

With 100 files you can find it in 6-7 tries.

-Alex
not a robot
User avatar
raph666
Administrator
Posts: 2428
Joined: March 9th, 2007
Location: dans la mer du nord
Reputation: 20
Contact:

Postby raph666 » Fri Apr 13, 2007 3:38 pm

Thanks Alex, it worked great and fast
didn't know what "binary search" was before you made me search for it but it surely is logic and efficient. I had a couple of .ini files that were causing problem, it was a bit longer than 6-7 tries but the binary chop idea is great! I'm happy to have learned something
Rogue_F
Member
Posts: 1504
Joined: November 2nd, 2006
Reputation: 1

Postby Rogue_F » Fri Apr 13, 2007 3:45 pm

What exactly was the problem in the .ini? something missing? funny characters?

-Alex
not a robot
User avatar
raph666
Administrator
Posts: 2428
Joined: March 9th, 2007
Location: dans la mer du nord
Reputation: 20
Contact:

Postby raph666 » Fri Apr 13, 2007 5:06 pm

Ok yes! it was all because of missing "artist ="
I feel kind of dumb because I searched for them without realizing that no artist was displayed ingame :p so it was easy to spot them actually

But well, it's really because of the song.ini . One funny thing is that I couldn't load those song...I mean I had the preview and previous highscores (previous to my rf-mod install) on the selection screen but when selecting it, it would look like if it was an empty folder (the reason for the string index out of range??). I guess you made it so the game see song.ini without the artist= as a "folder.ini", is it to support the use of folder labels?
Last edited by raph666 on Fri Apr 13, 2007 5:07 pm, edited 1 time in total.
Rogue_F
Member
Posts: 1504
Joined: November 2nd, 2006
Reputation: 1

Postby Rogue_F » Fri Apr 13, 2007 7:04 pm

Yeah, someone mentioned that before. I had forgotten to fix it. I'll try to squeeze that in before I post it tonight.

-Alex
whatakevin
Member
Posts: 1273
Joined: February 12th, 2007
Reputation: 0

Postby whatakevin » Fri Apr 13, 2007 8:01 pm

arg.... i guess il have to uninstall the new FoF
whatakevin
Member
Posts: 1273
Joined: February 12th, 2007
Reputation: 0

Postby whatakevin » Fri Apr 13, 2007 8:43 pm

damit, i did a clean reinstall and i still got a error, but this time a different one. i copied all files in data folder to the FoF data folder. i overwrote the old FoF ones. i copied the Fretsonfire.exe over and overwrote and when i launch it tells me error has occored and to chek the logbook thing. the logbook tells me

Traceback (most recent call last):
File "FretsOnFire.py", line 68, in ?
File "GameEngine.pyo", line 190, in
File "Resource.pyo", line 141, in fileName
File "ntpath.pyo", line 91, in join
TypeError: unsubscriptable object

Return to “FOF Mod Discussion and Support”

Who is online

Users browsing this forum: No registered users and 11 guests