FoFiX 3.121 Bugs or issues you'd like fixed?

[weirdpeople]

We are planning to release a FoFiX 3.122 bugfix release. So i know there are some issues out there regarding phase shift compatibility, and possibly some other bugs.

So if you know of any bugs, issues, or incompatibilities please post them in this thread, and maybe we can fix them for a future 3.122 release.

Thanks, Matthew

Link to branch on githuib:
https://github.com/fofix/fofix/commits/maintenance-3.x

[raynebc]

I brought up the Sysex issue quite a while ago and I believe they have already patched it in FoFiX's MIDI parsing code.

[weirdpeople]

Yeah I applied that patch 3 years ago to master, it was also one of the first things i applied to the 3.x branch.

edit:
Also i never quite looked into this, are Sysex Events actually ever used for anything that EOF, or phase shift supports?

[raynebc]

Tons of notations are written with Sysex messages, most of which are supported by Phase Shift:
http://dwsk.proboards.com/thread/404/so ... vancements

Most of them relate to pro guitar/drums, but some of them could be suitable for use in FoFiX:
Open strum notes
Slider/tap notes (basically no strum sections)

[weirdpeople]

Thanks, so I might have to look deeper into the crashing issues, because the previous patch was more a work around not a full fix. So do you have any midi files with sysex events in them i can test, or know of where i can get some?

[raynebc]

Modern Phase Shift charts would be a good place to check. Or you could use an 1.8 version of EOF to make a simple chart that uses any of those techniques.

[weirdpeople]

So i got around to fixing what i think was root the cause for the sysex events crash. commit here: https://github.com/fofix/fofix/commit/e ... 82a59a9b88

Now i haven't yet applied this fix to the 3.x branch, because I have a plan that will make that basically make doing that pointless once i get around to implementing support in the 3.x branch.

Read the post I made in the FoFiX Development thread for more info:
viewtopic.php?f=32&t=42311&p=637427#p637427

[raynebc]

If you improved the MIDI parser to actually have Sysex handling, then that's fine, but if all you did was remove the change NewCreature made regarding the ignoring of Sysex events, it's not going to fix the issue. See the original conversation about it here:
viewtopic.php?p=604069#p604069

[weirdpeople]

The fix is a 1 line typo fix:

self.outstream.sysex_event(data) -> self.outstream.system_exclusive(data)

-- Edit: Wed Oct 21, 2015 4:08 pm --

If you look at the log here it clearly points directly to this issue..
https://code.google.com/p/fofix/issues/ ... =1&q=sysex

[raynebc]

That is good news then. Let me know as future releases correct the Sysex handling, and I can update EOF's documentation accordingly.