Really awesome mod tho, makes it fun to play!
Alarian mod v2.7 - Full release
I think it would be cool if on the setlist or song selection screen, you could exit back to the main menu... Unless it's already coded and i'm un-aware of it lol. I find myself stuck there all the time having a change of heart, but have to back out of 3 or 4 subfolders to return to the main menu... I like my songs organized lol
Really awesome mod tho, makes it fun to play!
Really awesome mod tho, makes it fun to play!
Wester Toes
-
kawaii_kumiko69
- Member
- Posts: 551
- Joined: October 30th, 2007
- Reputation: 1
-
trinidude4
- Member
- Posts: 395
- Joined: March 22nd, 2008
- Reputation: 0
bladziak wrote:Hi. I have mac and I useing version 2.36. This version work wonderfull on mac but 2.5, 2.5b and 2.5c look beautifull but when I play song :/ I can't get score x4. I wait on new version. I hope is new version be better.
You probably have to adjust your AV-Delay. Look at the first post for instructions on how to do this. For the Mac version, though, it might be easier to use EOF to figure out the AV-Delay so you don't have to keep restarting the game: https://www.fretsonfire.org/cgi-bin....y218730
Last edited by trinidude4 on Fri May 23, 2008 7:33 am, edited 1 time in total.
Disco Skulls FTW!
-
Death Legion
- Member
- Posts: 934
- Joined: December 15th, 2007
- Location: Sci-Fi art collection: > 340 MB
- Reputation: 0
...the pain
-
myfingershurt
- Member
- Posts: 1796
- Joined: April 9th, 2007
- Location: Northern Nevada, USA
- Reputation: 0
Cool... I'm really still not sure why the "lefty mode fix" affects anyone else's game play. Here's the code in guitarscene.py that I changed, in case anyone is wondering:
From this (just the first line and the following indentations change):
...to this:
I still think the "new" code should be there all the time, but I can't explain why it was causing Aduro to have pull-off issues.
Does anyone else use Lefty Mode without that patch? Think I should have that change automatic if Lefty Mode is selected, or is there any objections to that?
Did anyone see if the patch affected the after-chord HOPO issues? I didn't have a chance to check that yet.
From this (just the first line and the following indentations change):
Code: Select all
  #if hopo == False:
  #first, iterate through activeList and check for the hopoLast key
  LastHopoFretStillHeld = False
  HigherFretsHeld = False
  for k in self.keysList[num]:
   if self.controls.getState(k):
    if self.guitars[num].keys[self.guitars[num].hopoLast] == k:
     LastHopoFretStillHeld = True
    elif k > self.guitars[num].keys[self.guitars[num].hopoLast]:
     #if any higher frets are held - let this pick through so it can fail!
     HigherFretsHeld = True
  #if len(activeList) == 1 and self.guitars[num].keys[self.guitars[num].hopoLast] == activeList[0]:
  if LastHopoFretStillHeld == True and HigherFretsHeld == False:
   if self.guitars[num].hopoActive != False and hopoFudge > 0 and hopoFudge < self.guitars[num].lateMargin:
    #here, a HOPO strum has all but been confirmed - we now need to EXCLUDE the special case
    #when a HOPO is followed by another of the same note in its' late margin before returning,
    #and also ensure that the hopoActive and hopoLast variables are reset to indicate the last note was    ÂÂ
    #strummed and not HOPO'd as originally assumed.
    if self.guitars[num].hopoActive < 0:
     #if last hopo active was tappable=3 (hopo end)...
     #the following funtion call returns all notes that might be valid
     #for a pick at this point in time - all early and late margins
     # - even if overlapping with the previous note's
     PotentialHopoStrumBugNotes = self.guitars[num].getRequiredNotes3(self.song, pos, hopo)
     #we already know, here, that we have the correct fret held down for the
     #last Hopo'd note -- then we might be in for a strum of the next, same
     #note. So - compare the two:
     if PotentialHopoStrumBugNotes:
      if PotentialHopoStrumBugNotes[0][1].number == self.guitars[num].hopoLast:
       #now, we know the next required note is the same note as last HOPO'd...
       #need the last HOPO'd note's time pos: abs(self.guitars[num].hopoActive) should return it
       #compare the time of the pick (pos) with the last HOPO'd note's time position
       #then compare the time of the pick with the next
       if( hopoFudge <= abs((PotentialHopoStrumBugNotes[0][0])-pos) ):
        #The pick occurred closer to the previous HOPO note than to the next same note
        #Looks like this might be a problem - so just skip this pick!
        #must make certain that this does not occur for the NEXT pick, which should be for the next note.
        #so:
        self.guitars[num].hopoLast = 0
        self.guitars[num].hopoActive = False
        PotentialHopoStrumBugNotes=[]
        return
     else:
      #no potential HOPO strum bug notes in sight: OK to just return and skip pick
      return
    else:
     #normal HOPO strum: may return normally and skip pick without regard for special cases
     return
...to this:
Code: Select all
  if hopo == False:
  #first, iterate through activeList and check for the hopoLast key
   LastHopoFretStillHeld = False
   HigherFretsHeld = False
   for k in self.keysList[num]:
    if self.controls.getState(k):
     if self.guitars[num].keys[self.guitars[num].hopoLast] == k:
      LastHopoFretStillHeld = True
     elif k > self.guitars[num].keys[self.guitars[num].hopoLast]:
      #if any higher frets are held - let this pick through so it can fail!
      HigherFretsHeld = True
   #if len(activeList) == 1 and self.guitars[num].keys[self.guitars[num].hopoLast] == activeList[0]:
   if LastHopoFretStillHeld == True and HigherFretsHeld == False:
    if self.guitars[num].hopoActive != False and hopoFudge > 0 and hopoFudge < self.guitars[num].lateMargin:
     #here, a HOPO strum has all but been confirmed - we now need to EXCLUDE the special case
     #when a HOPO is followed by another of the same note in its' late margin before returning,
     #and also ensure that the hopoActive and hopoLast variables are reset to indicate the last note was    ÂÂ
     #strummed and not HOPO'd as originally assumed.
     if self.guitars[num].hopoActive < 0:
      #if last hopo active was tappable=3 (hopo end)...
      #the following funtion call returns all notes that might be valid
      #for a pick at this point in time - all early and late margins
      # - even if overlapping with the previous note's
      PotentialHopoStrumBugNotes = self.guitars[num].getRequiredNotes3(self.song, pos, hopo)
      #we already know, here, that we have the correct fret held down for the
      #last Hopo'd note -- then we might be in for a strum of the next, same
      #note. So - compare the two:
      if PotentialHopoStrumBugNotes:
       if PotentialHopoStrumBugNotes[0][1].number == self.guitars[num].hopoLast:
        #now, we know the next required note is the same note as last HOPO'd...
        #need the last HOPO'd note's time pos: abs(self.guitars[num].hopoActive) should return it
        #compare the time of the pick (pos) with the last HOPO'd note's time position
        #then compare the time of the pick with the next
        if( hopoFudge <= abs((PotentialHopoStrumBugNotes[0][0])-pos) ):
         #The pick occurred closer to the previous HOPO note than to the next same note
         #Looks like this might be a problem - so just skip this pick!
         #must make certain that this does not occur for the NEXT pick, which should be for the next note.
         #so:
         self.guitars[num].hopoLast = 0
         self.guitars[num].hopoActive = False
         PotentialHopoStrumBugNotes=[]
         return
      else:
       #no potential HOPO strum bug notes in sight: OK to just return and skip pick
       return
     else:
      #normal HOPO strum: may return normally and skip pick without regard for special cases
      return
I still think the "new" code should be there all the time, but I can't explain why it was causing Aduro to have pull-off issues.
Does anyone else use Lefty Mode without that patch? Think I should have that change automatic if Lefty Mode is selected, or is there any objections to that?
Did anyone see if the patch affected the after-chord HOPO issues? I didn't have a chance to check that yet.
Last edited by myfingershurt on Fri May 23, 2008 3:37 pm, edited 1 time in total.
Disco Skulls FTW!
-
Death Legion
- Member
- Posts: 934
- Joined: December 15th, 2007
- Location: Sci-Fi art collection: > 340 MB
- Reputation: 0
I don't use the after-chord HOPOs (it make me fail, I prefer strum), so I can't help you in that way... But I think too that if Lefty Mode is selected, this fix should be applied automatically. Cause me and my brother play on the same computer but he's right-handed (thx to luck, he's actually playing only on easy/medium so he doesn't use much HOPOs, so I can use this fix XD).
Puppetz fan club member 
...the pain
-
myfingershurt
- Member
- Posts: 1796
- Joined: April 9th, 2007
- Location: Northern Nevada, USA
- Reputation: 0
I have created a test song with speedpicked chord / pulloff / chord / pulloff / chord / pulloff and have determined that the so-called "lefty mode fix" has also caused the after-chord HOPOs to behave correctly (I was able to speedpick every note without resetting my streak, and could also use pull-offs if I preferred). Here is a bug report for this issue.
I also have found some other small issues with the after-chord HOPOs and very specialized note patterns, as well as a problem with the very last after-chord HOPO merging with its chord if it comes too close to the end of a song. I have fixed these all, as well as a crash bug that was caused by a user trying to pause or restart the song during the "you rock" display.
So... here's Hotfix #2 for Alarian v2.5c - unzip this file and replace your data\library.zip with the library.zip included in the archive to apply the fix. Aduro, I don't know what to tell you man, I can make a special version for you if this causes your pull-off issue again but this the way the logic is supposed to be.
As always, the source code is included. I only altered song.py (my markhopoGH2 function) and guitarscene.py (the dopickGH2 function as well as some additional logic where the You Rock message is initiated and some variable resetting at the beginning of restartsong.
Remember, my hotfixes are cumulative - the latest fix contains all previous fixes unless otherwise noted.
Hotfix #2 - Link:
****Fixed case where a chord pull-off before a long pause would result in that chord-pulloff requiring a strum
****Fixed case where a chord pull-off too close to the end of a song would result in a funky half-HOPO half-chord merged strum
****Fixed crash that happened when user pauses during "You Rock" message
****Fixed problem where user managed to restart during "You Rock" message before the crash, and the game would try to restart and then immediately go to the results screen.
---------------------
History:
note: no need to download old hotfixes unless the latest causes a new problem for you.
Hotfix #1 (Link) - Ensured that special strummed HOPO logic does not get applied to tapped or pulled-off notes. This has fixed speedpicked chord / pulloff / chord / pulloff / etc issues. Here is a bug report for this issue.
This is the so-called "Lefty Mode" fix. Also: Code changes
I also have found some other small issues with the after-chord HOPOs and very specialized note patterns, as well as a problem with the very last after-chord HOPO merging with its chord if it comes too close to the end of a song. I have fixed these all, as well as a crash bug that was caused by a user trying to pause or restart the song during the "you rock" display.
So... here's Hotfix #2 for Alarian v2.5c - unzip this file and replace your data\library.zip with the library.zip included in the archive to apply the fix. Aduro, I don't know what to tell you man, I can make a special version for you if this causes your pull-off issue again but this the way the logic is supposed to be.
As always, the source code is included. I only altered song.py (my markhopoGH2 function) and guitarscene.py (the dopickGH2 function as well as some additional logic where the You Rock message is initiated and some variable resetting at the beginning of restartsong.
Remember, my hotfixes are cumulative - the latest fix contains all previous fixes unless otherwise noted.
Hotfix #2 - Link:
****Fixed case where a chord pull-off before a long pause would result in that chord-pulloff requiring a strum
****Fixed case where a chord pull-off too close to the end of a song would result in a funky half-HOPO half-chord merged strum
****Fixed crash that happened when user pauses during "You Rock" message
****Fixed problem where user managed to restart during "You Rock" message before the crash, and the game would try to restart and then immediately go to the results screen.
---------------------
History:
note: no need to download old hotfixes unless the latest causes a new problem for you.
Hotfix #1 (Link) - Ensured that special strummed HOPO logic does not get applied to tapped or pulled-off notes. This has fixed speedpicked chord / pulloff / chord / pulloff / etc issues. Here is a bug report for this issue.
This is the so-called "Lefty Mode" fix. Also: Code changes
Last edited by myfingershurt on Fri May 23, 2008 2:41 pm, edited 1 time in total.
...the pain
-
myfingershurt
- Member
- Posts: 1796
- Joined: April 9th, 2007
- Location: Northern Nevada, USA
- Reputation: 0
Daevid - if I had any idea how to code that I would help out. Unfortunately, the only area I really know what's happening is the actual gameplay and HOPO system. All the other things I fixed were found serendipitously - I fix things as I stumble across obvious issues
If someone points me to a chunk of code that needs to be altered, and I have alternate Rock Band main menu graphics available to me (I just don't do graphics... they would suck if I did!) -- then I could probably make it happen.
BTW - if anyone finds problematic note patterns with the after-chord HOPOs, please confirm by performing multiple tests with the various HOPO options, and then create a blank song containing just the problematic pattern and send it to me to use for debugging. Please ensure that your test song exhibits the same problem, if not you need to include more surrounding notes.
edit: Kawaii:
I believe there are separate variable labels in song.ini for those two options. Here's how to figure out the difference:
1) locate a song that displays "As Made Famous By" when starting up, open it's song.ini and see what label it uses.
2) locate a song that displays "As Performed By" when starting up, open it's song.ini and see what label it uses.
Then you should know how to do what you want.
edit2:
I believe for "as made famous by" you use "artist=artistname" - and for "as performed by" you use "cover=artistname"
I have not confirmed this, but I seem to remember artist and cover being the two variable labels.
If someone points me to a chunk of code that needs to be altered, and I have alternate Rock Band main menu graphics available to me (I just don't do graphics... they would suck if I did!) -- then I could probably make it happen.
BTW - if anyone finds problematic note patterns with the after-chord HOPOs, please confirm by performing multiple tests with the various HOPO options, and then create a blank song containing just the problematic pattern and send it to me to use for debugging. Please ensure that your test song exhibits the same problem, if not you need to include more surrounding notes.
edit: Kawaii:
Quick question: Is there anything that I have to put in the song.ini or wherever so that it will say "As Made Famous By" instead of "As Performed By"?
I believe there are separate variable labels in song.ini for those two options. Here's how to figure out the difference:
1) locate a song that displays "As Made Famous By" when starting up, open it's song.ini and see what label it uses.
2) locate a song that displays "As Performed By" when starting up, open it's song.ini and see what label it uses.
Then you should know how to do what you want.
edit2:
I believe for "as made famous by" you use "artist=artistname" - and for "as performed by" you use "cover=artistname"
I have not confirmed this, but I seem to remember artist and cover being the two variable labels.
Last edited by myfingershurt on Fri May 23, 2008 2:49 pm, edited 1 time in total.
-
Kabouter18
- Member
- Posts: 9
- Joined: May 21st, 2008
- Reputation: 0
...the pain
-
myfingershurt
- Member
- Posts: 1796
- Joined: April 9th, 2007
- Location: Northern Nevada, USA
- Reputation: 0
-
Kabouter18
- Member
- Posts: 9
- Joined: May 21st, 2008
- Reputation: 0
Return to “FOF Mod Discussion and Support”
Who is online
Users browsing this forum: No registered users and 14 guests